Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make methods more readable. #33

Closed
elbeicktalat opened this issue Nov 6, 2021 · 1 comment · Fixed by #35
Closed

Make methods more readable. #33

elbeicktalat opened this issue Nov 6, 2021 · 1 comment · Fixed by #35
Assignees
@elbeicktalat
Labels
invalid This doesn't seem right
Projects
flutter_auth_buttons

Comments

@elbeicktalat
Copy link
Owner

I'm sure you will take a while to understand what's happening in the following method.

flutter_auth_buttons/lib/src/buttons/twitter_auth_button.dart

Line 40 in b8448f4

String getIconUrl() {

So this does not following any kind of clean code.
@elbeicktalat elbeicktalat added the invalid This doesn't seem right label Nov 6, 2021
@elbeicktalat elbeicktalat self-assigned this Nov 6, 2021
@elbeicktalat elbeicktalat added this to Backlog in flutter_auth_buttons via automation Nov 6, 2021
@elbeicktalat elbeicktalat moved this from Backlog to To Do in flutter_auth_buttons Nov 6, 2021
@elbeicktalat elbeicktalat moved this from To Do to In progress in flutter_auth_buttons Nov 7, 2021
@elbeicktalat elbeicktalat linked a pull request Nov 7, 2021 that will close this issue
More readable #35
Merged
3 tasks
flutter_auth_buttons automation moved this from In progress to Done Nov 11, 2021
@elbeicktalat
Copy link
Owner Author

Same code after fix:

flutter_auth_buttons/lib/src/buttons/twitter_auth_button.dart

Line 44 in 83d78a6

String getIconUrl() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elbeicktalat elbeicktalat

Labels
invalid This doesn't seem right
Projects
flutter_auth_buttons
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More readable elbeicktalat/flutter_auth_buttons
1 participant
@elbeicktalat