Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More readable #35

Merged
merged 18 commits into from
Nov 11, 2021
Merged

More readable #35

merged 18 commits into from
Nov 11, 2021

Conversation

elbeicktalat
Copy link
Owner

@elbeicktalat elbeicktalat commented Nov 7, 2021 •
edited
Loading

  • simplify getIconUrl method.
  • simplify getButtonColor method.
  • simplify getTextStyle method.

elbeicktalat
elbeicktalat commented Nov 7, 2021
View reviewed changes
Copy link
Owner Author

@elbeicktalat elbeicktalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine.
Waiting for text style simplification.

@elbeicktalat elbeicktalat added this to In progress in flutter_auth_buttons via automation Nov 7, 2021
@elbeicktalat elbeicktalat linked an issue Nov 7, 2021 that may be closed by this pull request
Make methods more readable. #33
Closed
@elbeicktalat elbeicktalat added the invalid This doesn't seem right label Nov 7, 2021
elbeicktalat
elbeicktalat commented Nov 11, 2021
View reviewed changes
Copy link
Owner Author

@elbeicktalat elbeicktalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine ready to merge.

@elbeicktalat elbeicktalat merged commit 83d78a6 into main Nov 11, 2021
flutter_auth_buttons automation moved this from In progress to Done Nov 11, 2021
@elbeicktalat elbeicktalat deleted the more_readable branch November 11, 2021 16:33
@elbeicktalat elbeicktalat restored the more_readable branch November 11, 2021 21:37
elbeicktalat added a commit that referenced this pull request Nov 11, 2021
@elbeicktalat
Revert "More readable (#35)"
00ffe83 
This reverts commit 83d78a6.
@elbeicktalat elbeicktalat mentioned this pull request Nov 11, 2021
Closed
@elbeicktalat elbeicktalat deleted the more_readable branch November 11, 2021 21:40
@elbeicktalat elbeicktalat restored the more_readable branch November 12, 2021 07:31
@elbeicktalat elbeicktalat deleted the more_readable branch November 12, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
flutter_auth_buttons
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make methods more readable.
1 participant
@elbeicktalat