-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with quotations in title #29
Comments
Also apologies if this isn't the place / format for this kind of thing, I've never used this aspect of Github |
Please provide a link for a manga title I could use for testing. |
Sorry, should've thought about that. Here is one of the chapters that has the problem: |
I'll take a look as soon as I can (which could be next week btw... time will say). Shouldn't be hard to track, probably some sanitization missing at some point. |
Awesone, thank you |
Could you please provide more details on how are you exactly downloading the chapters? Because I cannot reproduce the issue 🤔 edit: ok sorry I did not realize about the actual error due to the screenshot provided. I'll take a look into it. |
I just enter in the terminal: Currently whenever I try with the site it says site not recognized though, the site was down for a week or so, so I think they may have changed some infrastructure stuff that is messing with the program. I tried finding other sites with quotes in the same chapter title but can't find any in the supported sites list that work at the moment (though I think this may just be an issue with my specific machine) |
That should not work because you're specifying a chapter url instead of the series one. The command you should use is: manga-downloader https://ww7.mangakakalot.tv/manga/manga-ev957056 240 Which fails with the provided error. I'll take a look when I can, I'm sorry I'm kinda busy these days and I cannot give the app the love it deserves. |
Chapters that include quotation marks in the title give an error saying " error saving file The World God Only Knows 240 - Chapter 240 ; The Present Time "tsukiyo&shiori".cbz: open The World God Only Knows 240 - Chapter 240 ; The Present Time "tsukiyo&shiori".cbz: The filename, directory name, or volume label syntax is incorrect. " I assume this is an issue with Windows not allowing " in filenames, and tried looking into the help command for changing the output name using --filename-template but the help command on my CMD for some reason is a bit of a mess to read, lots of random symbols and numbers injected into the lines, and I have tried a few naming templates, but it keeps saying it needs at least 1 arg and received 0.
![image](https://private-user-images.githubusercontent.com/78249414/304583896-ebead4c4-8049-4470-ad79-64eb9fa22f3e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxMDUxNTAsIm5iZiI6MTcyMDEwNDg1MCwicGF0aCI6Ii83ODI0OTQxNC8zMDQ1ODM4OTYtZWJlYWQ0YzQtODA0OS00NDcwLWFkNzktNjRlYjlmYTIyZjNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA0VDE0NTQxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4MjgyYTIwMDg4NDMyZmE4ZWQ4MzhjMDZhNGJjYWY1MzU0ODQzMDJhODM0NWE0NTM1ODlhNzg3NTE0ODY1YWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UDrWOtVWvr8nUrL1pGAlM8t99KAtVIxHLCixy0VwRN8)
The text was updated successfully, but these errors were encountered: