Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with quotations in title #29

Closed
Sirnight282 opened this issue Feb 14, 2024 · 8 comments · Fixed by #32
Closed

Issues with quotations in title #29

Sirnight282 opened this issue Feb 14, 2024 · 8 comments · Fixed by #32
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Sirnight282
Copy link

Chapters that include quotation marks in the title give an error saying " error saving file The World God Only Knows 240 - Chapter 240 ; The Present Time "tsukiyo&shiori".cbz: open The World God Only Knows 240 - Chapter 240 ; The Present Time "tsukiyo&shiori".cbz: The filename, directory name, or volume label syntax is incorrect. " I assume this is an issue with Windows not allowing " in filenames, and tried looking into the help command for changing the output name using --filename-template but the help command on my CMD for some reason is a bit of a mess to read, lots of random symbols and numbers injected into the lines, and I have tried a few naming templates, but it keeps saying it needs at least 1 arg and received 0.
image

@Sirnight282
Copy link
Author

Also apologies if this isn't the place / format for this kind of thing, I've never used this aspect of Github

@elboletaire
Copy link
Owner

Please provide a link for a manga title I could use for testing.

@Sirnight282
Copy link
Author

Sorry, should've thought about that. Here is one of the chapters that has the problem:
https://ww7.mangakakalot.tv/chapter/manga-ev957056/chapter-240

@elboletaire
Copy link
Owner

I'll take a look as soon as I can (which could be next week btw... time will say). Shouldn't be hard to track, probably some sanitization missing at some point.

@Sirnight282
Copy link
Author

Awesone, thank you

@elboletaire elboletaire added bug Something isn't working good first issue Good for newcomers labels Feb 14, 2024
@elboletaire
Copy link
Owner

elboletaire commented Mar 15, 2024

Could you please provide more details on how are you exactly downloading the chapters? Because I cannot reproduce the issue 🤔

edit: ok sorry I did not realize about the actual error due to the screenshot provided. I'll take a look into it.

@Sirnight282
Copy link
Author

I just enter in the terminal:
manga-downloader https://ww7.mangakakalot.tv/chapter/manga-ev957056/chapter-240

Currently whenever I try with the site it says site not recognized though, the site was down for a week or so, so I think they may have changed some infrastructure stuff that is messing with the program. I tried finding other sites with quotes in the same chapter title but can't find any in the supported sites list that work at the moment (though I think this may just be an issue with my specific machine)

@elboletaire
Copy link
Owner

I just enter in the terminal: manga-downloader ww7.mangakakalot.tv/chapter/manga-ev957056/chapter-240

That should not work because you're specifying a chapter url instead of the series one. The command you should use is:

manga-downloader https://ww7.mangakakalot.tv/manga/manga-ev957056 240

Which fails with the provided error. I'll take a look when I can, I'm sorry I'm kinda busy these days and I cannot give the app the love it deserves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants