Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sendgrid_api_key dependency from Settings #54

Closed
verisadmin opened this issue Jun 9, 2017 · 0 comments · Fixed by #68
Closed

Remove sendgrid_api_key dependency from Settings #54

verisadmin opened this issue Jun 9, 2017 · 0 comments · Fixed by #68

Comments

@verisadmin
Copy link

  • I am working on this library . And I was thinking of using your libray for SendGrid, But you have a strong dependency of mentioning Send_Grid_API in settings.

  • If you can make it possible that user can either mention api_key in settings or pass it as function argument too (If you think its feasible and makes sense).

  • Why Remove Settings dependency ?

    • So that user can use as many service as he wants by simple passing the key in Function and let function do the rest of work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant