Custom_Args Feature #53
Conversation
I updated the version of sendgrid and because of this I had to change how data is assigned to the helpers (Mail, Personalization and Attachment) classes. I also added the CustomArgs helper to be sent to sendgrid.
Added custom_args feature
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 60.22% 61.95% +1.72%
==========================================
Files 1 1
Lines 88 92 +4
Branches 22 25 +3
==========================================
+ Hits 53 57 +4
Misses 29 29
Partials 6 6
Continue to review full report at Codecov.
|
| @@ -14,7 +14,7 @@ | |||
| license='MIT', | |||
| description='SendGrid Backend for Django', | |||
| long_description=open('./README.rst').read(), | |||
| install_requires=["sendgrid >= 3.5, < 4"], | |||
| install_requires=["sendgrid >= 3.5, < 4.0.4"], | |||
There was a problem hiding this comment.
This change implies that django-sendgrid is compatible with sendgrid 4. Is this actually the case? And if so, why don't we correct the entire version range?
There was a problem hiding this comment.
Yes the latest version of the python-sendgrid package is version 4.0.0. It was unnecessary that I changed it to 4.0.4. I do not remember why I did it.
$ Pip freeze | Grep -i sendgrid
Sendgrid == 4.0.0
-e git + https: //github.com/lucassimon/sendgrid-django.git@8df68d527f1783392dca7e84bbf04606120c4ac7#egg=sendgrid_django
And if so, why do not we fix the whole range of versions?
What are the other versions that should be changed? The same dependency is only from python-sendgrid and changed the main version of this package:
There was a problem hiding this comment.
Yes, I understand that the python-sendgrid package has hit version 4. I also understand that we previously did not allow django-sendgrid to be installed alongside python-sendgrid version 4.
This change now allows for django-sendgrid to be installed along python-sendgrid version 4. Does django-sendgrid actually support python-sendgrid version 4?
Added Custom_Args Feature to get the values in webhook.
How can I add unit test and run?