fix: add a disposal phase for the cellx benchmark #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No worries! On the contrary, thank you for taking time to improve the benchmarks 馃槈. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is continuation for #27. Now that the number of runs per tier has been bumped to 100, cellx is still trashing the JS heap.
This pull request alleviates the problem by explicitly disposing the root cells after each cellx run. It's not exactly fair towards the other libraries to give special care and attention for cellx in this manner, but it's skewing the results for the libraries following it. For example (on my machine, ymmv) hyperactiv performs much better in the 1000 tier benchmark when the cellx cells are disposed (hyperactiv's score improving to ~1600 from ~4500).
Sorry to bother you like this 馃槄