Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo bubbling, fix "bind" bugs, exclude Dates, Observable/Computable mixins, WebSocket+RPC support #6

Closed
wants to merge 30 commits into from

Conversation

zgsrc
Copy link
Contributor

@zgsrc zgsrc commented Feb 26, 2018

Some objects don't have prototypes. Some objects are dates.

@coveralls
Copy link

coveralls commented Feb 26, 2018

Coverage Status

Coverage decreased (-1.1%) to 98.889% when pulling b9f10e3 on zgsrc:master into 818f783 on elbywan:master.

@zgsrc
Copy link
Contributor Author

zgsrc commented Feb 26, 2018

Dates are hard to observe.

@zgsrc zgsrc changed the title Bug fix Redo bubbling/handler paradigm, fix "bind" bugs/exclude Dates from isObj, Observable/Computable mixins Feb 28, 2018
@zgsrc zgsrc changed the title Redo bubbling/handler paradigm, fix "bind" bugs/exclude Dates from isObj, Observable/Computable mixins Redo bubbling, fix "bind" bugs/exclude Dates from isObj, Observable/Computable mixins Feb 28, 2018
@zgsrc zgsrc changed the title Redo bubbling, fix "bind" bugs/exclude Dates from isObj, Observable/Computable mixins Redo bubbling, fix "bind" bugs, exclude Dates, Observable/Computable mixins Feb 28, 2018
@zgsrc zgsrc changed the title Redo bubbling, fix "bind" bugs, exclude Dates, Observable/Computable mixins Redo bubbling, fix "bind" bugs, exclude Dates, Observable/Computable mixins, WebSocket+RPC support Feb 28, 2018
@elbywan
Copy link
Owner

elbywan commented May 25, 2019

@zgsrc Thank you very much for this great contribution! 👍

I'm deeply sorry that I did not have time to review it before, I've been quite busy in the past 10 months.

Your commits are now merged with couple of modifications. I also added unit tests and split the documentation and code a bit further.

I'm going to release v0.4.0 right away 📦 .

Thanks again!

@elbywan elbywan closed this May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants