Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out undefined queryParameters #148

Closed
davidspiess opened this issue Oct 14, 2022 · 2 comments
Closed

Filter out undefined queryParameters #148

davidspiess opened this issue Oct 14, 2022 · 2 comments
Labels
bug

Comments

@davidspiess
Copy link 

.query({ a: undefined, b: "hello"  })

converts to a=undefined&b=hello

Wouldn't it be better to strip undefined values altogether?
elbywan added a commit that referenced this issue Oct 15, 2022
@elbywan
🐛 Query addon should strip undefined values
be2d2ef 
Should solve #148
@elbywan elbywan added the bug label Oct 15, 2022
elbywan added a commit that referenced this issue Oct 15, 2022
@elbywan
🐛 Query addon should strip undefined values
ce395b5 
Should solve #148
@elbywan
Copy link
Owner

elbywan commented Oct 15, 2022

Hey @davidspiess, thanks for reporting the issue 🙇

Wouldn't it be better to strip undefined values altogether?

It would definitely, I just released 2.1.5 including the fix.

@elbywan elbywan closed this as completed Oct 15, 2022
@davidspiess
Copy link
Author

Thank you very much 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidspiess @elbywan