Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the exact property behaviour to give more flexibility to the matches #14

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

elchininet
Copy link
Owner

This pull request changes the exact property behaviour to make it more flexible to match elements.

For example:

  1. <a data-panel="ui-configured">UI Configured</a>
  2. <a data-panel="config">Instellingen</a>
  3. <a data-panel="instellingen">Instellingen</a>

Before

  • With item in config and exact in false it matched number 1.
  • With item in config and exact in true it didn‘t match any item because none of them have config as text.

After

  • With item in config and exact in false it matches number 1.
  • With item in config and exact in true it matches number 2 because its data-panel is exactly config.

@elchininet elchininet added the fix label Jan 6, 2024
@elchininet elchininet merged commit b087cdb into master Jan 6, 2024
2 of 3 checks passed
@elchininet elchininet deleted the fix_exact_property branch January 6, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant