Add certificate_model to Configuration #15

telsaiori · 2019-10-05T17:01:15Z

Add certificate_model for user to customize model
Replace LetsEncrypt::Certificate to LetsEncrypt.config.certificate_model.constantize
Update README
How to trigger callbacks for inherited certificate class in app #14

…del.constantize

coveralls · 2019-10-05T17:06:21Z

Coverage decreased (-0.01%) to 87.757% when pulling 6e579ed on telsaiori:issue14 into 1f079f6 on elct9620:master.

app/controllers/lets_encrypt/verifications_controller.rb

…odel name

spec/controllers/lets_encrypt/verifications_controller_spec.rb

…d customize model

spec/controllers/lets_encrypt/verifications_controller_spec.rb

lib/letsencrypt.rb

spec/letsencrypt_spec.rb

telsaiori added 3 commits October 6, 2019 00:49

Add certificate_model for user to customize model

ad7b04d

Replace LetsEncrypt::Certificate to LetsEncrypt.config.certificate_mo…

a4470ca

…del.constantize

Update README for certificate_model

b7086d1

elct9620 reviewed Oct 5, 2019

View reviewed changes

app/controllers/lets_encrypt/verifications_controller.rb Outdated Show resolved Hide resolved

telsaiori added 2 commits October 6, 2019 02:39

Load certificate_model from config

5096392

Add class method LetsEncrypt.certificate_model to get the customize m…

a68cd9e

…odel name

elct9620 requested changes Oct 6, 2019

View reviewed changes

spec/controllers/lets_encrypt/verifications_controller_spec.rb Outdated Show resolved Hide resolved

Add test to check controller will work properly with default model an…

80918bd

…d customize model

elct9620 requested changes Oct 6, 2019

View reviewed changes

spec/controllers/lets_encrypt/verifications_controller_spec.rb Outdated Show resolved Hide resolved

spec/controllers/lets_encrypt/verifications_controller_spec.rb Outdated Show resolved Hide resolved

Move certificate_model config test to letsencrypt_spec

0d27adb

elct9620 requested changes Oct 6, 2019

View reviewed changes

spec/controllers/lets_encrypt/verifications_controller_spec.rb Show resolved Hide resolved

Move let!(:certificate) to each context

33239dc

elct9620 requested changes Oct 6, 2019

View reviewed changes

spec/controllers/lets_encrypt/verifications_controller_spec.rb Show resolved Hide resolved

Add test to check callback will work in customize model

b431122

telsaiori force-pushed the issue14 branch from be97876 to b431122 Compare October 7, 2019 10:15

elct9620 requested changes Oct 7, 2019

View reviewed changes

lib/letsencrypt.rb Outdated Show resolved Hide resolved

elct9620 requested changes Oct 7, 2019

View reviewed changes

spec/letsencrypt_spec.rb Outdated Show resolved Hide resolved

telsaiori force-pushed the issue14 branch from 99de083 to a507211 Compare October 7, 2019 18:26

elct9620 requested changes Oct 8, 2019

View reviewed changes

spec/letsencrypt_spec.rb Outdated Show resolved Hide resolved

Use double pipe in certificate_model method and edit the test for it

6e579ed

telsaiori force-pushed the issue14 branch from a507211 to 6e579ed Compare October 8, 2019 04:18

elct9620 merged commit e05c85e into elct9620:master Oct 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add certificate_model to Configuration #15

Add certificate_model to Configuration #15

telsaiori commented Oct 5, 2019

coveralls commented Oct 5, 2019 •

edited

Loading

Add certificate_model to Configuration #15

Add certificate_model to Configuration #15

Conversation

telsaiori commented Oct 5, 2019

coveralls commented Oct 5, 2019 • edited Loading

coveralls commented Oct 5, 2019 •

edited

Loading