Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Goals #89

Open
paltman opened this issue Oct 3, 2017 · 1 comment
Open

Rewrite Goals #89

paltman opened this issue Oct 3, 2017 · 1 comment

Comments

@paltman
Copy link
Contributor

paltman commented Oct 3, 2017

I want to rewrite this library with the following goals in mind:

  • drop requirement on using jQuery (I think all the DOM manipulation can be handled with a little discipline referencing this guide
  • drop $.ajax wrapper around XMLHttpRequest for native fetch API which is supported everywhere except IE 11 and Opera mini
  • drop polyfills (don't think they are needed at all right now)
  • switch to Jasmine and Karma for testing
  • rewrite in a way that is more testable. the current method of everything in nested anonymous functions makes things near impossible.
@paltman
Copy link
Contributor Author

paltman commented Oct 3, 2017

Some sources show a fairly high level of IE 11 usage. So we might need a polyfill of some sort for fetch.

paltman added a commit that referenced this issue Oct 3, 2017
@paltman
Start of rewrite
3fda21f 
We start with a new test framework with Jasmine and Karma, followed
by the start of exposing things outside of the anonymous blocks so
we can test better.

Lots of work to port the rest of the tests. This commit only ports
a handful so that we can establish a beach head on the new approach.

We'll focus on other items in this branch as part of #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paltman