Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group-Folder contents are shown as per-user duplicates #40

Closed
robertoschwald opened this issue Dec 7, 2023 · 12 comments · Fixed by #48
Closed

Group-Folder contents are shown as per-user duplicates #40

robertoschwald opened this issue Dec 7, 2023 · 12 comments · Fixed by #48

Comments

@robertoschwald
Copy link

We use group-folders.

occ duplicates:list shows all group-folder files as duplicates for all users:

/user1/files/FOLDER/FOLDER/file1.jpg
/user2/files/FOLDER/FOLDER/file1.jpg
...
10 paths are hidden because they reference to a similiar file

and so on.

@eldertek
Copy link
Owner

eldertek commented Dec 8, 2023

In fact it is not an issue x), because app lists all references to same file.

If you want to only per user duplicates, specify it as an argument.

@rustyscottweber
Copy link

No.. this is for sure a majorly annoying issue:
ObviousProblem

None of these files are actually duplicates and the plugin needs to be capable of discerning this.

@eldertek
Copy link
Owner

Yes, sure can you give me the api list please.

@eldertek
Copy link
Owner

Up ?

@rustyscottweber
Copy link

apologies, but I'm not sure what you mean by the api list.

@eldertek
Copy link
Owner

@rustyscottweber
Copy link

rustyscottweber commented Feb 14, 2024

{"status":"success","entities":[{"id":85707,"type":"file_hash","hash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","files":[{"id":279191,"owner":"Russell.Weber","path":"\/Andrew.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"45f9a8cc8768f48b74c8c5e66fb3ee1fa81a8cfd","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T19:06:10+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":279193,"owner":"Russell.Weber","path":"\/Annesha.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"f69a4ef66d7ceb9b64a35fe795e8eb2f85d4d0c0","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T19:06:12+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":280979,"owner":"Russell.Weber","path":"\/Benjamin.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"184439a4d24d0f2b3c874b5349f52c89301216ec","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T19:07:57+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":542135,"owner":"Russell.Weber","path":"\/Beth.Bollinger\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"635b80d5ac3fc81a42def93ce2d4df1bc383ceaa","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2024-01-13T06:28:05+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":281014,"owner":"Russell.Weber","path":"\/Bryce.Bollinger\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"8bc63922e0f56b8a5e15ca5f926386d016a32c76","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T19:08:01+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":318909,"owner":"Russell.Weber","path":"\/Garth.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"706b365ff17960e2661aa53cc56cb8a60fd06d50","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T19:54:45+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":373267,"owner":"Russell.Weber","path":"\/Joseph.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"87576ff31c716f47d33fe33195427f4d13095413","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T22:18:18+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":373269,"owner":"Russell.Weber","path":"\/Mary.Nuttall\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"85444975b414b530be1e2a64c718481237fa2afd","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T22:18:22+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":374803,"owner":"Russell.Weber","path":"\/Michael.Nuttall\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"63aa87e474f00225d91b5b7628783a551d55364a","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T22:19:55+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":424640,"owner":"Russell.Weber","path":"\/Russell.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"9da97cdd4530c8baed11883f8cb1f8966c935c07","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-19T23:17:09+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":535161,"owner":"Russell.Weber","path":"\/Sarah.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"23c7853d6032ba1b5c99d4d720f1b13888cdc68b","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-20T05:24:26+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":538363,"owner":"Russell.Weber","path":"\/Shari.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"51173de09709d2cd72e45922c70b70481b3536e3","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-20T05:34:43+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false},{"id":538365,"owner":"Russell.Weber","path":"\/Sienna.Weber\/files\/Weberbia\/Important Recordings\/grandma daynes funeral.wav","pathHash":"b6ef9076e6f69a576b2012b4e4ea2d8340ff9abb","fileHash":"48ad431c015701f64010704d48c881e5ea19136300d9cfe3a12f2544066f69f5","imageHash":null,"updatedAt":"2023-11-20T05:34:46+0000","nodeId":null,"mimetype":"audio\/wav","size":148444204,"ignored":false}],"acknowledged":false},{"id":85708,"type":"file_hash","hash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","files":[{"id":279192,"owner":"Russell.Weber","path":"\/Andrew.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"80225c73962f2c2f3c9992c81af0f2206cc9edb8","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T19:06:12+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":279194,"owner":"Russell.Weber","path":"\/Annesha.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"660a7416ab07b629aabf60fae8a18010a3ce4b93","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T19:06:12+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":280980,"owner":"Russell.Weber","path":"\/Benjamin.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"96627d7b5802f5b04dfa012d7a3c88cad192b93b","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T19:07:57+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":542136,"owner":"Russell.Weber","path":"\/Beth.Bollinger\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"42547c2853e909de5dcf746ae2292effd3b9889a","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2024-01-13T06:28:11+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":281015,"owner":"Russell.Weber","path":"\/Bryce.Bollinger\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"25be382c8bfe3cdcf67f89a77c26f701326a37f0","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T19:08:01+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":318910,"owner":"Russell.Weber","path":"\/Garth.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"0b47f6e40f71e1ba55d58b3eb2efd4b65d7fb048","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T19:54:46+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":373268,"owner":"Russell.Weber","path":"\/Joseph.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"6dfd4968fbd34be5d7bd526358f8c1d283a55c5d","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T22:18:18+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":373270,"owner":"Russell.Weber","path":"\/Mary.Nuttall\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"9afb0e4cb319041088ecfee1795d220d856d9b4c","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T22:18:23+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":374804,"owner":"Russell.Weber","path":"\/Michael.Nuttall\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"f479c858f8c1fe06fb5a0e1b2ff7fdcfc56d862f","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T22:19:55+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":424641,"owner":"Russell.Weber","path":"\/Russell.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"023c67eb22a9cefa15d6db6a6d8536ab0398cfe7","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-19T23:17:09+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":535162,"owner":"Russell.Weber","path":"\/Sarah.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"f72297b2ed33d6932d2184804a06f85b83ef4dec","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-20T05:24:26+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":538364,"owner":"Russell.Weber","path":"\/Shari.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"4a6f6f73106d43cd140a989e34bd0d108620cddb","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-20T05:34:43+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false},{"id":538366,"owner":"Russell.Weber","path":"\/Sienna.Weber\/files\/Weberbia\/Important Recordings\/grandma grave dedication.wav","pathHash":"1ead7e0d9a19b3ccb3bfbc7f80f48d221c51350e","fileHash":"2b6774f175b6aa43f2ceb6621c738ee83f51cb118d6992514abbf1189127a7c8","imageHash":null,"updatedAt":"2023-11-20T05:34:46+0000","nodeId":null,"mimetype":"audio\/wav","size":4851244,"ignored":false}],"acknowledged":false}],"pagination":{"currentPage":1,"totalPages":2387,"totalItems":71610,"limit":30}}

The issue here is that, even though I might be the owner, all of the paths listed are just aliases to the same shared group folder for different users that aren't me. All of the duplicate paths are paths that I, as a next cloud user, don't have access to because they aren't in my next cloud path.
I, as a user, have no access to the file:
"/Annesha.Weber/files/Weberbia/Important Recordings/grandma grave dedication.wav"
because it is a file, in a shared folder, for a different user. However, it shows up as a duplicate for me, the logged in user.

@eldertek
Copy link
Owner

So you said all of theses users share the same file with nextcloud share functionnality right ?

@rustyscottweber
Copy link

rustyscottweber commented Feb 14, 2024

This was shared using the "Group Folder" plugin which is a featured plugin.
https://apps.nextcloud.com/apps/groupfolders
However, I would imagine you would get a similar result if the folder were shared in any similar manner.

@eldertek
Copy link
Owner

You think it is preferable to not include shared files in duplicates detection ?

@rustyscottweber
Copy link

rustyscottweber commented Feb 14, 2024

That's just the thing: they might be a shared folder, but none of the paths to the duplicate file are my path to the file, with the exception of 1. The other paths to the duplicate are user specific for other users. Even though I might be listed as the owner of the file, there is no way I can delete the other duplicates with the file path supplied as the path doesn't exist for me.
So, you can include shared files, but the reporting needs to be duplicates that the user actually has access to (not just a file the user owns on someone else's path).

@eldertek
Copy link
Owner

It will be fixed by v1.1.5, only available on Nextcloud 28.

eldertek added a commit that referenced this issue Feb 15, 2024
@eldertek eldertek mentioned this issue Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants