Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Duplicates on 1.1.7 #52

Closed
Routhinator opened this issue Feb 21, 2024 · 4 comments
Closed

No Duplicates on 1.1.7 #52

Routhinator opened this issue Feb 21, 2024 · 4 comments

Comments

@Routhinator
Copy link

Just upgraded from 1.1.6 > 1.1.7 and all the duplicates I was working through have seemingly vanished, but it seems more likley the app is not querying for them.

Since I have a lot of duplicates the load delay is normally quite visible, and on 1.1.6 it would show no duplicates for up to 45-60 seconds while the javascript loaded the results from the async request.

But on 1.1.7 there's just nothing. Page instantly loads and looking at the network requests, there's nothing pending. It seems to never hit the endpoint.

Currently trying to work out if there is a way to rollback to work out what query isn't getting called and... that's new territory for me, but wanted to flag this behaviour.

@Routhinator
Copy link
Author

Oh it is making the call - the return is just broken:

Response from /apps/duplicatefinder/api/duplicates/all?limit=50&page=1:

{"status":"success","entities":[],"pagination":{"currentPage":1,"totalPages":150,"totalItems":7499,"limit":50}}

Uh with 150 total pages and 50 items per page, there should not be an empty entities object, I would say.

@eldertek
Copy link
Owner

Can we fix this on discord please ? #eldertek

@Routhinator
Copy link
Author

Sent an invite.

eldertek added a commit that referenced this issue Feb 21, 2024
@eldertek
Copy link
Owner

Fixed by v1.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants