Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about increaseXYZ methods #14

Open
SirYwell opened this issue Feb 5, 2022 · 0 comments
Open

Think about increaseXYZ methods #14

SirYwell opened this issue Feb 5, 2022 · 0 comments
Milestone

Comments

@SirYwell
Copy link
Member

SirYwell commented Feb 5, 2022

Currently, SemanticVersion has the methods increaseMajor(), increaseMinor() and increasePatch(). The current implementation increments the specific version part, but it does not reset the following parts to zero.

While this is okay as long as it's documented accordingly, it might not be useful this way. Maybe these methods should be replaced by nextMajor(), nextMinor() and nextPatch methods.

While this might be more clear, it's still discussable what happens to the pre-release and the build part when using those methods.

For that reason, it might be better to not include neither of the mentioned methods in the initial release but rather add them later, depending on requirements and feedback.

@SirYwell SirYwell added this to the 1.0.0 milestone Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant