Set comparator to default on continuous pulse #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
reviewed
May 24, 2024
|
I have incorporated this manually and fixed the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took longer than I expected to find the time to submit this change, but it's to fix #26
@eldruin - Going to be honest, I have no idea what those tests you mentioned in that issue are suppose to do in this particular case. It looks like it's suppose to check that it doesn't break the boards that don't use it as a conversion-ready pulse? But I'm not sure this function call would be appropriate at all for those boards that don't support it anyways.