Remove DynamicOneShot trait.
#19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
5 times, most recently
from
fe3a67a
to
78aafb3
Compare
eldruin
reviewed
Jan 24, 2024
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
from
78aafb3
to
bd95c9c
Compare
|
@eldruin, rebased the PRs. |
eldruin
requested changes
Jan 30, 2024
| @@ -235,7 +235,7 @@ impl BitFlags { | |||
| } | |||
|
|
|||
| pub mod channel; | |||
| pub use channel::{ChannelId, ChannelSelection}; | |||
| pub use channel::ChannelId; | |||
There was a problem hiding this comment.
I do not think we should expose ChannelSelection publicly.
| #[doc = $doc] | ||
| $CH, | ||
| )+ | ||
| mod private { |
There was a problem hiding this comment.
Why do you move this module inside this macro?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
This way the ChannelId is sealed by making ChannelSelection private.
|
|
||
| /// Marker type for an ADC input channel. | ||
| pub trait ChannelId<T>: private::Sealed { | ||
| pub trait ChannelId<T> { |
There was a problem hiding this comment.
Why should this trait not be sealed?
There was a problem hiding this comment.
It is actually sealed since the ChannelSelection type is private.
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
from
d796952
to
dad963e
Compare
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
from
dad963e
to
4f46a6e
Compare
|
@eldruin, can you have another look here? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reading #10 (comment), it looks like adding this trait didn't actually solve the issue.
Depending on the device, this also allows reading invalid channels.