Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset_internal_driver_state. #22

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

reitermarkus
Copy link
Contributor

A device can already be reset by destroying and recreating it. Also, calling reset_internal_driver_state in Continuous mode is wrong, since the device will be in OneShot mode after a reset.

@reitermarkus reitermarkus force-pushed the remove-reset branch 3 times, most recently from 88f617f to ac046fb Compare January 19, 2024 14:09
@coveralls
Copy link

Coverage Status

coverage: 81.974% (+0.7%) from 81.277%
when pulling eb540ff on reitermarkus:remove-reset
into 9cc7956 on eldruin:master.

Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eldruin eldruin merged commit 698c817 into eldruin:master Jan 30, 2024
22 checks passed
@reitermarkus reitermarkus deleted the remove-reset branch January 30, 2024 16:27
Copy link

@KidiIT KidiIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reviewed and approved🫶❤️

@KidiIT
Copy link

KidiIT commented Feb 1, 2024

All checked🌚❤️ and successfully approved✅

Copy link

@KidiIT KidiIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful approved✅🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants