- fixed running method

- inverted CH flag in run tests
- reflected changes in the changelog.

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Updated internal use of `chrono`.
 - Updated `embedded-hal-mock` dev-dependency.
 - Updated MSRV to 1.62.0.
+- [breaking-change] Swap implementations of `set_running` and `halt`, inverted output of `running` as CH bit was interpreted incorrectly.
 
 ## [0.4.0] - 2022-02-19
 

src/run.rs

@@ -7,7 +7,7 @@ where
 {
     /// Read if the clock is running.
     pub fn running(&mut self) -> Result<bool, Error<E>> {
-        self.register_bit_flag_high(Register::SECONDS, BitFlags::CH)
+        Ok(!self.register_bit_flag_high(Register::SECONDS, BitFlags::CH)?)
     }
 
     /// Set the clock to run (default on power-on).

tests/run_halt.rs

@@ -2,39 +2,39 @@ use embedded_hal_mock::i2c::Transaction as I2cTrans;
 mod common;
 use crate::common::{destroy, new, Register, ADDR};
 
-get_test!(running, running, true, trans_read!(SECONDS, [0b1000_0000]));
-get_test!(not_running, running, false, trans_read!(SECONDS, [0]));
+get_test!(running, running, true, trans_read!(SECONDS, [0]));
+get_test!(not_running, running, false, trans_read!(SECONDS, [0b1000_0000]));
 
 #[test]
 fn can_set_running() {
     let mut dev = new(&[
-        I2cTrans::write_read(ADDR, vec![Register::SECONDS], vec![0b0101_0101]),
-        I2cTrans::write(ADDR, vec![Register::SECONDS, 0b1101_0101]),
+        I2cTrans::write_read(ADDR, vec![Register::SECONDS], vec![0b1101_0101]),
+        I2cTrans::write(ADDR, vec![Register::SECONDS, 0b0101_0101]),
     ]);
     dev.set_running().unwrap();
     destroy(dev);
 }
 
 #[test]
 fn set_running_when_already_running_does_nothing() {
-    let mut dev = new(&trans_read!(SECONDS, [0b1000_0000]));
+    let mut dev = new(&trans_read!(SECONDS, [0b0000_0000]));
     dev.set_running().unwrap();
     destroy(dev);
 }
 
 #[test]
 fn can_halt() {
     let mut dev = new(&[
-        I2cTrans::write_read(ADDR, vec![Register::SECONDS], vec![0b1101_0101]),
-        I2cTrans::write(ADDR, vec![Register::SECONDS, 0b0101_0101]),
+        I2cTrans::write_read(ADDR, vec![Register::SECONDS], vec![0b0101_0101]),
+        I2cTrans::write(ADDR, vec![Register::SECONDS, 0b1101_0101]),
     ]);
     dev.halt().unwrap();
     destroy(dev);
 }
 
 #[test]
 fn halt_when_already_halted_does_nothing() {
-    let mut dev = new(&trans_read!(SECONDS, [0]));
+    let mut dev = new(&trans_read!(SECONDS, [0b1000_0000]));
     dev.halt().unwrap();
     destroy(dev);
 }