Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Config with explicit register types. #17

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Replace Config with explicit register types. #17

merged 1 commit into from
Aug 16, 2022

Conversation

reitermarkus
Copy link
Contributor

No description provided.

@eldruin
Copy link
Owner

eldruin commented Aug 10, 2022

Do we need a higher MSRV?

@reitermarkus
Copy link
Contributor Author

const_panic is in 1.57. I have replaced the unreachable! with a default match case instead for now.

@eldruin
Copy link
Owner

eldruin commented Aug 10, 2022 •
edited

Uh, sorry but commit fc24b44 contains way too many fiddly changes for me to review timely. It will take me a while to go over it. A mitigation would be splitting into several commits, if that is something you would be willing to do.

@reitermarkus
Copy link
Contributor Author

Sure, I'll try to split some of this out.

@reitermarkus reitermarkus mentioned this pull request Aug 10, 2022
Merged
@reitermarkus
Copy link
Contributor Author

I extracted some of this out into #19.

@reitermarkus reitermarkus force-pushed the register-types branch 3 times, most recently from 775d15f to 85bfab3 Compare August 11, 2022 21:46
@reitermarkus reitermarkus mentioned this pull request Aug 11, 2022
Merged
@reitermarkus reitermarkus force-pushed the register-types branch 2 times, most recently from 10d7665 to 232f47d Compare August 12, 2022 20:12
@reitermarkus
Copy link
Contributor Author

reitermarkus commented Aug 16, 2022 •
edited

@eldruin, I think this should be good to go now. Don't think I can split this further.

This was referenced Aug 16, 2022
Merged
Merged
eldruin
eldruin approved these changes Aug 16, 2022
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your work!

@eldruin eldruin merged commit 591a33b into eldruin:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reitermarkus @eldruin