Fix charge_rate when discharging #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
reviewed
Dec 9, 2023
bencochran
force-pushed
the
fix-charge-rate
branch
from
96ca091
to
b659476
Compare
|
Done! Let me know if you’d like to see any other changes. |
|
Thank you! |
MAX17048 & MAX17049 report negative `CRATE` values when discharging, so interpret them as i16 instead of u16 before converting to f32. Resolves eldruin#1
bencochran
force-pushed
the
fix-charge-rate
branch
from
b659476
to
6b2510d
Compare
|
Ah, forgot to Thanks for getting builds working again! |
|
Thanks! And thanks for the library! |
|
You are welcome. Thanks to you too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1, MAX17048 & MAX17049 yield negative
CRATEvalues when discharging, so interpret them as i16 instead of u16 before converting to f32.(I’m relatively new to Rust so feel free to point me towards a different idiom to use here if you’d prefer)
Fixes #1