Removed second delay on eeprom writes #2
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the second delay during EEPROM writes. This delay is due to the note in the datasheet that a delay of 5ms (conservatively 10ms) between eeprom writes is required to prevent bugs. I've confirmed this: Wacky stuff happens if you don't delay!
This PR is due to the delay being inconsistent: We need the one between the writes. Currently, the onus is on the user to execute delays otherwise, ie between reads, or between read and write commands. I see two options:
#1: This PR as-is, ie removing all internal delays except the one between two writes. The user must insert delays etc in their code.
#2: Add a delay after or before each read. This would avoid the user having to add delays, but adds latency in situations where it may not be needed