Skip to content

Commit

Permalink
Use new logging API for python extension logger and LS logger (micros…
Browse files Browse the repository at this point in the history
…oft#21062)

In this PR:
1. Changes the python extension logging to use LogOutputChannel
2. Changes the language server logger with LogOutputChannel
3. Test output channel uses OutputChannel as it needs to show test
output and not really logging. Also, using logging test output makes it
pretty much unreadable.
4. Simplifies logging channel and output channel registration.

We need to do this now to make it easier for new test work to integrate
with output logging.

For microsoft#20844

This still doesn't get rid of the log level setting.
  • Loading branch information
karthiknadig authored and eleanorjboyd committed May 12, 2023
1 parent 5d969cb commit 82451b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/test/activation/node/analysisOptions.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { NodeLanguageServerAnalysisOptions } from '../../../client/activation/no
import { ILanguageServerOutputChannel } from '../../../client/activation/types';
import { IWorkspaceService } from '../../../client/common/application/types';
import { PYTHON, PYTHON_LANGUAGE } from '../../../client/common/constants';
import { ILogOutputChannel } from '../../../client/common/types';
import { IExperimentService, ILogOutputChannel } from '../../../client/common/types';

suite('Pylance Language Server - Analysis Options', () => {
class TestClass extends NodeLanguageServerAnalysisOptions {
Expand Down

0 comments on commit 82451b3

Please sign in to comment.