Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to filter the comments by length (min and max number of characters) #261

Merged
merged 8 commits into from
Jun 7, 2022
Merged

Option to filter the comments by length (min and max number of characters) #261

merged 8 commits into from
Jun 7, 2022

Conversation

DomizianoScarcelli
Copy link
Contributor

@DomizianoScarcelli DomizianoScarcelli commented Jun 4, 2022

I added a .env variable called COMMENT_LENGTH_RANGE="min,max" that allows the user to filter the comments by length range.

If the user leaves the variable empty, the range is automatically set to (0, Infinity).

I implemented this because I found it annoying that some videos were very long and occupied only by a couple of long and boring comments.

Fixes #260

@callumio callumio added the enhancement New feature or request label Jun 5, 2022
@callumio callumio changed the base branch from master to develop June 6, 2022 19:58
Copy link
Collaborator

@callumio callumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant idea, thanks for the contribution!

@callumio callumio merged commit a05a43f into elebumm:develop Jun 7, 2022
@DomizianoScarcelli DomizianoScarcelli deleted the filter-comments-by-length branch June 7, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDEA: Having the option to pick the comments only in a certain range of length
2 participants