Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically sized select tick #3

Closed
bitstarr opened this issue Dec 2, 2016 · 2 comments
Closed

Dynamically sized select tick #3

bitstarr opened this issue Dec 2, 2016 · 2 comments

Comments

@bitstarr
Copy link

bitstarr commented Dec 2, 2016

Sorry, i'm too lazy to make a pull request for the following detail.

The .select class uses background-size to size the SVG tick. Use .8rem instead of 12px for a more flexible styling.

BTW i really like this project. It provides a very good styling with minimal foot print.

cheers.

@electerious
Copy link
Owner

electerious commented Dec 4, 2016

Generally a good idea, but I would say that when we use rem for the select we should also use rem for the background-size of the control. The problem here is that relative units often lead to half pixels. That way the dot in the radio control would look a bit more like a egg.

@bitstarr
Copy link
Author

bitstarr commented Dec 5, 2016

good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants