Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate SQL used in analyzer #84

Open
ericmtsai opened this issue Sep 14, 2020 · 1 comment
Open

Consolidate SQL used in analyzer #84

ericmtsai opened this issue Sep 14, 2020 · 1 comment

Comments

@ericmtsai
Copy link
Contributor

There is a lot of repeated SQL in the database module that is used only by the Analyzer. This varies only in a couple areas: the select statement and the Candidate vs BallotMeasure joins. See here, here, and here.

These should be consolidated into one function that creates the SQL to support the various areas where the query is used.

@wstlabs
Copy link

wstlabs commented Sep 21, 2020

@ericmtsai - yup - there's got to be a cleaner way to do this stuff.

If you want at some point we can walk through the surrounding code (and the data pipeline as a whole) and try to figur something out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants