Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "SRV" to "STAR" in 5vse.png image #45

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Change "SRV" to "STAR" in 5vse.png image #45

merged 3 commits into from
Apr 6, 2023

Conversation

endolith
Copy link
Collaborator

No description provided.

@endolith
Copy link
Collaborator Author

Wait I already did this in #27 It got lost somehow?

@endolith
Restore small version of 5vse.png image
400313b 
This was enlarged in e8ebb2f, but I think this small version is useful,
too, so making it available in the same folder.
@endolith
Hand-modify "IRV" to "IRV/RCV" in 5vse.png images
7c91320 
(Was intended to be done in e8ebb2f but wasn't.)

I guessed the font as Arial Bold 11.
@endolith
Copy link
Collaborator Author

endolith commented Apr 6, 2023

OK so:

  1. I fixed SRV → STAR in 11755f3
  2. @fsargent intended to change Irv → IRV/RCV in e8ebb2f but actually just made the image bigger and (probably unintentionally) changed STAR back to SRV in the process
  3. @fsargent reduced file sizes of images in 3b371f9 but I don't see any actual changes

Anyway I forgot I have commit rights to this repo, so I guess I can fix it myself. 😃 If no one has any comments I will commit it in a day or so.

I also restored the small version of the image alongside the big one, and changed IRV → IRV/RCV in both, as was intended in e8ebb2f.

@endolith endolith assigned endolith and fsargent and unassigned endolith Apr 6, 2023
@endolith endolith requested a review from fsargent April 6, 2023 19:15
@endolith
Copy link
Collaborator Author

endolith commented Apr 6, 2023

Oh I guess I can't do it myself. @fsargent can you approve this PR?

@fsargent fsargent merged commit a055f53 into electionscience:main Apr 6, 2023
@endolith endolith deleted the STAR_image branch April 6, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsargent fsargent fsargent approved these changes

Assignees

@fsargent fsargent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@endolith @fsargent