Skip to content
This repository has been archived by the owner on May 6, 2019. It is now read-only.

select: revert select's dropdown icon to default #127

Merged
merged 11 commits into from
Jun 6, 2018
Merged

Conversation

Hyjaz
Copy link
Contributor

@Hyjaz Hyjaz commented Jun 2, 2018

screen shot 2018-06-02 at 2 12 14 pm

This is a fix for issue #103

I removed the following three css properties from select html tag:

-webkit-appearance:none;-moz-appearance:none;appearance:none

@ivangabriele
Copy link
Contributor

Where are the original Sass or CSS files from which this file has been generated ?

@Hyjaz
Copy link
Contributor Author

Hyjaz commented Jun 2, 2018

For <select /> it's here

It was indeed sort of a bad idea to separate the electra-desktop css. It is kinda harder to maintain in the long term.

@ivangabriele
Copy link
Contributor

It was not a bad idea. But how we do it seems wrong. We should have it as a git submodule or a npm dependency (a npm dependency being easier to handle imo) so that we have to update it to generate the css on this project.

In the meantime, can you add a PR on the Electra-Styleguide too ?

@Hyjaz
Copy link
Contributor Author

Hyjaz commented Jun 2, 2018

The corresponding PR has been opened on Electra-Styleguide - electracoin-ECA/electra-styleguide#2

@@ -25,6 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Mnemonic recovery.
- Hidden normal quitting error (acting as an install-update-and-quit instead of a simple daemon closing).
- Missing prefixes in (crypto)currencies top shown values.
- Payments page caret down icon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a change, it's a fix ;) Changed is for stuff that worked before and has been changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's under Fixed already

@ivangabriele ivangabriele merged commit 9265f76 into master Jun 6, 2018
@Hyjaz Hyjaz deleted the fix-select branch June 6, 2018 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants