Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electric): Fix unbounded WAL size growth on disk #1099

Merged
merged 7 commits into from
Apr 4, 2024
Merged

fix(electric): Fix unbounded WAL size growth on disk #1099

merged 7 commits into from
Apr 4, 2024

Conversation

alco
Copy link
Member

@alco alco commented Mar 26, 2024 •
edited
Loading

As explained in #1083 (comment), Electric cannot let Postgres know it can discard obsolete WAL records until it sees a write to an electrified table.

Here we issue such writes on a regular basis even if there are no user writes being performed by the clients or directly in the database.

Fixes #1083.

  • add changelog
  • add a test that confirms that periodic writes are happening

@linear Linear
Copy link

linear bot commented Mar 26, 2024

VAX-1751 Replica size / disk usage

@alco alco force-pushed the alco/vax-1751-unbounded-wal-size-growth-on-disk branch from 0f9fe8a to aa29063 Compare March 26, 2024 14:53
@alco alco mentioned this pull request Apr 2, 2024
Merged
magnetised
magnetised approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@magnetised magnetised left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic writes.

@icehaunter icehaunter merged commit 419e7b2 into main Apr 4, 2024
5 checks passed
@icehaunter icehaunter deleted the alco/vax-1751-unbounded-wal-size-growth-on-disk branch April 4, 2024 12:10
@alco alco mentioned this pull request Apr 4, 2024
Merged
alco added a commit that referenced this pull request Apr 9, 2024
@alco
chore(electric): Add an explanation for magic writes in LogicalReplic…
87b5bf3 
…ationProducer (#1127)

This was supposed to go into
#1099 but that got merged
too soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icehaunter icehaunter icehaunter left review comments

@magnetised magnetised magnetised approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replica size / disk usage
3 participants
@alco @magnetised @icehaunter