fix(electric): Fix a data race that may occur when a client is sufficiently behind the latest Postgres state #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
9dfdaa9
to
6f3cf33
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
2 times, most recently
from
498d287
to
513ece2
Compare
alco
changed the title
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
513ece2
to
29a7a18
Compare
alco
force-pushed
the
alco/code-cleanups
branch
2 times, most recently
from
668518c
to
82033ba
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
29a7a18
to
affe5c3
Compare
Base automatically changed from
alco/code-cleanups
to
alco/vax-1686-refactor-cached-wal-ets-backed
April 10, 2024 16:15
alco
force-pushed
the
alco/vax-1686-refactor-cached-wal-ets-backed
branch
from
79c68d4
to
8af60bd
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
affe5c3
to
f14c8da
Compare
alco
changed the base branch from
alco/vax-1686-refactor-cached-wal-ets-backed
to
alco/origin-based-cleanup
alco
force-pushed
the
alco/origin-based-cleanup
branch
2 times, most recently
from
34a0181
to
da7d367
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
3 times, most recently
from
e72f2b4
to
ef20224
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
54e4bdb
to
5b9352a
Compare
alco
force-pushed
the
alco/vax-1686-reserve-cached-transactions
branch
from
5b9352a
to
4aaf792
Compare
|
Moved to a different branch - #1199. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following edge case:
This leads to the client having an inconsistent state with the server.
The way this is addressed is by implementing a reservation system inside the cache to prevent it from dropping reserved transactions even if they are already outside of the cached WAL window size.