Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electric): Use the same TCP options for epgsql and Ecto connections #1292

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

alco
Copy link
Member

@alco alco commented May 22, 2024

Fixes #1278.

I have verified this fix by building a custom Docker image for this commit and deploying it to a DigitalOcean droplet that has IPv6 connectivity. The sync service connected to Supabase, the Ecto repo pool initialized successfully.

Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had ran into some issues with the Postgrex and epgsql configs not matching (the no SSL fallback issue) so I've left a comment about the connection timeout configuration as well, figured we might want to match that config as well (?)

@alco alco merged commit e8e4e3b into main Jun 4, 2024
7 checks passed
@alco alco deleted the alco/ecto-repo-tcp-opts branch June 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MODULE ERROR: Electric.Replication.PostgresConnector
2 participants