Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): Correcly coalesce command complete messages #998

Conversation

magnetised
Copy link
Contributor

@magnetised magnetised commented Feb 22, 2024

A query with multiple statements expects multiple command complete messages with a single closing ReadyForQuery message. This fixes incorrect handling of that situation within the prisma shadow handler

Hopefully fixes #955 and #939

Copy link

linear bot commented Feb 22, 2024

A query with multiple statements expects multiple command complete
messages with a single closing ReadyForQuery message. This fixes
incorrect handling of that situation within the prisma shadow handler
@magnetised magnetised force-pushed the garry/vax-1664-error-executing-prisma-migrations-via-electricsql-proxy branch from baef155 to 9a816b8 Compare February 22, 2024 17:34
@magnetised magnetised requested a review from alco February 22, 2024 19:17
Copy link
Member

@alco alco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@magnetised magnetised merged commit 209192a into main Feb 26, 2024
5 checks passed
@magnetised magnetised deleted the garry/vax-1664-error-executing-prisma-migrations-via-electricsql-proxy branch February 26, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error executing Prisma Migrations via ElectricSQL proxy
2 participants