JSON conf #9
Open
JSON conf #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
November 6, 2013 19:08
currently using and I don't want to deal with that now.
layed down beforehand Conflicts: manifests/instance.pp
…e're currently using and I don't want to deal with that now." This reverts commit 7e7b485.
tmclaugh
referenced
this pull request
in danjung/puppet-lumberjack
Nov 7, 2013
Otherwise you will not be able to create the /etc/lumberjack/${name} directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds a $json_conf parameter that can be toggled to create a JSON formatted lumberjack config. Setting it to true will alter how the $hostname and $files parameters work.
NOTE: This relies on a function called sorted_json() which I found as a gist on GitHub and no license. I've contacted the author regarding this. The functionality is unusable without this.
ref. https://gist.github.com/halkeye/2287885
Additionally, this PR fixes some other minor issues I ran into while testing my changes