Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Updated fruits and vegetables in footprints.yml file #207

Merged
merged 7 commits into from
Oct 20, 2019

Conversation

Aonepathan
Copy link
Contributor

Used Median Values from provided document, adding Conversion section just as the Apples example had. I added missing fruits/vegetables that were not in the list as well, left intensityKilograms and source properties as null for those items.

Did not include:

  • Fruit Salad
  • Dried fruit
  • Canned Beans
  • Sweet Corn
  • Vegetable Dishes
  • Soup
    (Please let me know if I should include them with the changes.)

Copy link
Contributor

@martincollignon martincollignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!

3 things before we can merge!

  • Would you mind commenting out or finding carbon intensity for items without? (Otherwise we can't show them in the app)

  • "Apple" in the example is the human unit. So for example for Blackberry it should probably say "serving" as 0.076 kg is unlikely to be one blackberry

  • The yaml needs to be lint checked. Can you make sure this is done?

Thanks again!

@Aonepathan
Copy link
Contributor Author

Understood. I tried searching for documentation online for carbon intensities for the fruits and vegetables but worried they're not reliable sources. Is there a document I could reference for the numbers? (I've commented those that don't have carbon intensity for now)

Example document I found: https://bioenv.gu.se/digitalAssets/1682/1682574_annika-ek.pdf

I've added the keyword 'Serving' to select fruits/vegetables to give the human unit estimate.

And had YAML and docs-yaml plugins installed to my vscode to lint the file, I wasn't able to find any errors, please let me know if there's another plugin you would prefer to get the file properly linted though

@martincollignon
Copy link
Contributor

martincollignon commented Oct 20, 2019

Thanks a lot @Aonepathan. This is so helpful! Keep on doing awesome work :) I've edited it a little bit to match what we expected (sorry for not being clear!)

@martincollignon martincollignon merged commit d5fa307 into electricitymaps:master Oct 20, 2019
@Aonepathan
Copy link
Contributor Author

@martincollignon thank you for the opportunity!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants