This repository has been archived by the owner on Mar 31, 2021. It is now read-only.
Updates eslint config and lints everything #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsnedergaard
commented
Nov 29, 2020
playground/.eslintrc.js
Outdated
| }, | ||
| rules: { | ||
| 'no-console': 'off', | ||
| 'import/no-unresolved': 'off', |
There was a problem hiding this comment.
Not sure why I'm getting errors from this rule 🤔
But since it's only for the playground, I guess it might be okay to disable it here for now?
There was a problem hiding this comment.
Hm, that a bit weird. Did you install the node_modules in the playground folder?
There was a problem hiding this comment.
Haha of course, missed that 😅
skovhus
approved these changes
Nov 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the linting setup to make it more similar to main repo. Also lints all files and fixes errors + warnings.
This was done in preparation for working on the models :)