Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Supports multiplying by number of participants in meal model #495

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

madsnedergaard
Copy link
Member

Issue

https://github.com/tmrowco/bloom/issues/338

Description

Updates Meal model to support multiplying the emission by number of meals/participants.

Changes

  • Wrote tests to cover existing model
  • Added new functionality
  • Bumped model version

Preview

image

⚠️ FYI/NOTE

I am not sure about best approach here with regards to name - I have here reused participants from transportation, but would it make more sense to have something like "numberOfMeals" instead? 🤔

I'm unsure if it's too weird that participants is multiplying emissions here, but dividing emissions in the transportation model.

@madsnedergaard madsnedergaard force-pushed the mn/models/supports-participants-in-meal branch from 3427def to 8ec2774 Compare December 1, 2020 12:58
Copy link
Contributor

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think numberOfMeals (mealCount?) is a better name. Participants is ambiguous, e.g. multiple people could share one meal.

@madsnedergaard
Copy link
Member Author

madsnedergaard commented Dec 1, 2020

I think numberOfMeals (mealCount?) is a better name. Participants is ambiguous, e.g. multiple people could share one meal.

Thanks, then "participants" stays transportation-specific and I will introduce a new numberOfMeals attribute :)

@madsnedergaard madsnedergaard merged commit 7d4437f into master Dec 1, 2020
@madsnedergaard madsnedergaard deleted the mn/models/supports-participants-in-meal branch December 1, 2020 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants