refactor: provide a Session default argument

electricitymaps · Oct 18, 2023 · c20e9c1 · c20e9c1
1 parent b8cd3a6
commit c20e9c1
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/parsers/CA_SK.py b/parsers/CA_SK.py
@@ -33,7 +33,7 @@
 
 
 def _request(
-    session: Session | None,
+    session: Session,
     target_datetime: datetime | None,
     url: str,
     zone_key: ZoneKey,
@@ -44,7 +44,6 @@ def _request(
     # The zone key must be "CA-SK"; bail out otherwise.
     if zone_key != "CA-SK":
         raise ParserException("CA_SK.py", f"Cannot parse zone '{zone_key}'", zone_key)
-    session = session or Session()
     # Mimic a user browser in the headers or the API will respond with a 403.
     response = session.get(url, headers={"user-agent": USER_AGENT})
     if not response.ok:
@@ -59,7 +58,7 @@ def _request(
 
 def fetch_production(
     zone_key: ZoneKey = ZoneKey("CA-SK"),
-    session: Session | None = None,
+    session: Session = Session(),
     target_datetime: datetime | None = None,
     logger: Logger = getLogger(__name__),
 ) -> list[dict[str, Any]]:
@@ -88,7 +87,7 @@ def fetch_production(
 
 def fetch_consumption(
     zone_key: ZoneKey = ZoneKey("CA-SK"),
-    session: Session | None = None,
+    session: Session = Session(),
     target_datetime: datetime | None = None,
     logger: Logger = getLogger(__name__),
 ) -> dict[str, Any]: