remove the US-SEC zone from US-FL so they don't overlap #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...using polygon-clipping.difference(). next commit will undo this and just build US-FL from the non-SEC Florida counties instead. for electricitymaps#1713
This reverts commit d239a74.
This reverts commit f133086.
|
Hi @snarfed , can you post a screenshot just so we can double check? |
|
oops, yes! sorry, should have done that originally.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1713. thanks to @systemcatch for the drastically simplifying suggestion in #1713 (comment)!
not a big deal, but if/when you all merge, maybe consider preserving the individual commits, ie merge or rebase instead of squashing. d239a74 in particular is a good example of how to subtract one arbitrary set of Topo/GeoJSON features from another, with
polygon-clipping.difference(). basically: