ZA parser: Integrated new CSV file format #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did they change the historical CSV files as well or do we need to keep the old code to parse historical values (from before the change)? |
|
There are no historical CSV files in that sense. There is always just one CSV containing values going back about 1-2 weeks from the current day (with a slight delay). E.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the new CSV file format from Eskom into the ZA parser. This fixes issue #4622.
Eskom now finally substituted their value seperator "," with ";", which leaves a correct (simply parseable) CSV file format.
The new file format, however, led to a parser failure, which has been fixed in this PR.
Previous discussion on the broken CSV file: #2881