Catches errors with Intl.NumberFormat and adds fallback #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kongkille
approved these changes
Oct 13, 2022
|
@madsnedergaard don't forget to push a new mobile build for this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #4630, closes #4570, closes #4533
Description
This catches exceptions where browsers don't support Intl.NumberFormat with unit param.
I considered if we could test in a smarter way, but seeing as formatJS also does a try-catch to check if it should polyfill, I reckon it should be fine to do the same :)
Preview
Only tested by throwing inside the try block, haven't actually tested on an older version of Safari