Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component tests for chart tooltips #5234

Merged
merged 7 commits into from
Mar 27, 2023
Merged

component tests for chart tooltips #5234

merged 7 commits into from
Mar 27, 2023

Conversation

tonypls
Copy link
Collaborator

@tonypls tonypls commented Mar 24, 2023

Issue

We love tests

Description

Add some simple component tests for the chart tooltips, it might be overkill to do the same for desktop and mobile.

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for phenomenal-syrniki-c5ceaa ready!

Name Link
🔨 Latest commit 2ed4f62
🔍 Latest deploy log https://app.netlify.com/sites/phenomenal-syrniki-c5ceaa/deploys/6421a8f75a63f100082b1616
😎 Deploy Preview https://deploy-preview-5234--phenomenal-syrniki-c5ceaa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@madsnedergaard
Copy link
Member

Seems like it can't find the date :)

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Nice work on getting those tests to work!

.github/workflows/cypress.yml Show resolved Hide resolved
@tonypls tonypls enabled auto-merge (squash) March 27, 2023 14:32
@tonypls tonypls merged commit e72ca19 into master Mar 27, 2023
@tonypls tonypls deleted the tvs/new-tests branch March 27, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants