-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PH production & exchanges parser #5769
PH production & exchanges parser #5769
Conversation
@@ -81,7 +82,8 @@ parsers = [ | |||
"tqdm", | |||
"openpyxl", | |||
"pydataxm", | |||
"odfpy"] | |||
"odfpy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove that, I forgot
Is this based on #679? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it work well with a few fixes (that we need to do). I have added more details in individual comments.
I think I'll pause the review here and do another one once the needed fixes are implemented at least.
PS: I think this parser could benefit from multithreading while fetching all the individual files.
PPS: I added the parser to the zone configs.
We did use some of the info dug at that time as a base :) |
Thanks @VIKTORVAV99 for the thorough review, sorry if it was still a bit messy |
…les' of https://github.com/electricitymaps/electricitymaps-contrib into pierresegonne/ele-2665-build-parser-for-merit-order-tables
@VIKTORVAV99 Ready to go, I did not implement multi-threading for parsing the production csvs because I think we're quite far from hitting the timeout, let's do it in a subsequent PR if we see that it happens? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some type erros still but nothing blocking as far as I am concerned. They seem to stem from the named tuples and dataframe changing the types (but not content).
Just one final note about the source (and one type error) but I'm approving already.
Nice work on this
Just one final as I just saw this in the console (should have scrolled up earlier 🙄):
Is that something we need to address first? |
Not directly, we'll leave the parser running and collect the non matched resources names in a week or so to try to match the remaining ones. By default, the non-matched will be set as unknown prod |
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
I'm curious to know, what command do you run to check this? |
I'm using the Pylance extension in VSCode that does type checking. |
…les' of https://github.com/electricitymaps/electricitymaps-contrib into pierresegonne/ele-2665-build-parser-for-merit-order-tables
Thank you for this PH parser, I've been waiting for this since I first learned about electricity maps and started contributing, Although I haven't updated the capacity for PH for a while now. I would like to inform that not all power plants in the PH are available in the Wholesale Electricity Market of the Philippines (WESM) governed by the Independent Electricity Market Operator of the Philippines (IEMOP). The plants listed under the WESM are those plants that are mandated to register based on the following parameters:
The PH has several power plants that are not registered under the WESM such as off-grid power plant operators. Unfortunately, no data is available online with regard to their operations. Under the Enhanced WESM design, power plant operators are required to submit/nominate their capacity at a 5-minute interval. Zones The Market Network Model of Enhanced WESM has 14 Zones as of September 2023: 1 - North Luzon 1 - 3 are located Luzon Grid
|
Issue
We don't have data for the Philippines, yet it is available
Description
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier --write .
andpoetry run format
to format my changes.