Upgrade IE parser to ParserFunctions

[VIKTORVAV99]

Issue

The IE parser was not using ParserFunctions

Description

This PR upgrades the existing parser to use parser functions as well as adding a parser function for total generation.

Double check

• I have tested my parser changes locally with poetry run test_parser "zone_key"
• I have run pnpx prettier --write . and poetry run format to format my changes.

[VIKTORVAV99]

Apparently we don't have a generation type for the parsers functions? Only generationForecast?

[VIKTORVAV99]

If it's easier to review I can rename this back to the original name and then just switch back before merging it.

[florianscheidl]

Sounds like a good idea :) Similarly, is there a file for the tests we previously used?

[VIKTORVAV99]

We did not have any tests before 😅

[VIKTORVAV99]

/review

[github-actions]

PR Analysis

• 🎯 Main theme: Upgrading the IE parser to use ParserFunctions and adding a parser function for total generation.
• 📝 PR summary: This PR focuses on upgrading the existing parser for Ireland (IE) to use parser functions. It also introduces a new parser function for total generation. The changes include modifications to the parser file, tests, and configuration files for the zones and exchanges.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 4, because the PR includes a significant amount of new code and changes across multiple files. It requires a good understanding of the parser functions and the specific implementation for the Ireland parser.
• 🔒 Security concerns: No

PR Feedback

• 💡 General suggestions: The PR is well-structured and includes relevant tests. It would be beneficial to ensure that all edge cases and potential exceptions are handled properly. Also, it's important to verify that the new parser function for total generation is working as expected and providing accurate data.

• 🤖 Code feedback:

  ---

  relevant file	parsers/SMARTGRIDDASHBOARD.py
  suggestion	Consider adding error handling for the case where the 'kind' parameter is not in the KINDS_AREA_MAPPING dictionary. This could prevent potential KeyErrors. [important]
  relevant line	"+ \"area\": KINDS_AREA_MAPPING[kind],"

  ---

  relevant file	parsers/SMARTGRIDDASHBOARD.py
  suggestion	It might be beneficial to add some logging statements in the fetch_data function to provide more visibility into the data fetching process, especially in case of errors. [medium]
  relevant line	"+def fetch_data("

  ---

  relevant file	parsers/SMARTGRIDDASHBOARD.py
  suggestion	Consider adding a check to ensure that the 'Value' key exists in the 'item' dictionary before accessing it. This could help avoid potential KeyErrors. [important]
  relevant line	"+ consumption=item[\"Value\"],"

  ---

  relevant file	parsers/SMARTGRIDDASHBOARD.py
  suggestion	It would be good to add error handling for the case where the 'zone_key' parameter is not in the REGION_MAPPING or EXCHANGE_MAPPING dictionaries. This could prevent potential KeyErrors. [important]
  relevant line	"+ \"region\": EXCHANGE_MAPPING[zone_key][\"key\"]"

  ---

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[VIKTORVAV99]

@florianscheidl adding you as a reviewer for this as I saw you where working on ELE-3449, this PR will give us some additional data that could be used to guide the estimation models.

[florianscheidl]

Overall looks very nice to me :)
I left some comments asking for clarification regarding fetch_generation and fetch_production, which confused me a bit.

[VIKTORVAV99]

I'll rename things again and then merge this 🙂