Tweak Thumbicon #6163
Merged
Tweak Thumbicon #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsnedergaard
approved these changes
Nov 22, 2023
Co-authored-by: Mads Nedergaard <nedergaardmads@gmail.com>
|
🥳 Thanks for fixing it @Kongkille! |
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where if selectedIndex is 0, the wrong icon is displayed (honestly, JS is the true culprit here).
Also did a few opinionated changes on the hover effect, which I guess are more optional hehe.
Hoping to see a lot of you on Friday! 🍺
Preview
Before:
After:
Screen.Recording.2023-11-21.at.22.50.51.mov
Double check
pnpx prettier --write .andpoetry run formatto format my changes.