-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase significant digits #6173
Increase significant digits #6173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me but I think it would be good to have a second pair of eyes take look at this as well.
So @madsnedergaard, @tonypls and @Alportan what do you guys think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does make sense to increase the accuracy of our data by adding decimals. 🙌 💡 Idea for the future: Agree on the number of decimals we display for different data points to ensure visual consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we all agree this would be a nice change.
However if you could update the chart to use 2 digits only that would be great!
I have set the BreakdownChart to 2 digits now because I've seen some zones in the map with labels such as "15 GW" that could be incorrectly rounded. Are there any checks in the code so that the calculated values in the labels only need 2 digits and never more? |
I do not think there are any calculated checks this in particular but since we are already using 2 decimals this should not cause any immediate issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for making the last changes!
@madsnedergaard does this adress your feedback? Turns out we had already made it possible to set the significants digits in specific places 🙂 |
Yes, let's merge it :) |
Issue
Closes #5921
Description
This PR increases the default number of digits used by the tooltips from 2 to 3. I believe this is better as it shows more detailed data, but it's open to discussion.
Preview
Before:
After:
Double check
pnpx prettier --write .
andpoetry run format
to format my changes.