Add support for fetching historical data for all French overseas regions #6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
commented
Dec 1, 2023
|
Leaving review up to @mathilde-daugy and @unitrium :) |
…_overseas_regions
|
@mathilde-daugy if you have the time could you give this a quick review so we can fetch the data before we re-run the flow tracing? |
madsnedergaard
approved these changes
Dec 15, 2023
…_overseas_regions
VIKTORVAV99
deleted the
vik/enable_full_historical_data_for_french_overseas_regions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently our historical data parsing doesn't work for all zones.
Description
While looking for something else entirely (capacity data) I found a nice dataset on the main EDF dataportal that has historical data for all the French overseas zones!
Double check
poetry run test_parser "zone_key"pnpx prettier --write .andpoetry run formatto format my changes.