-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update discharge emission factors and overrides CH #6260
Conversation
PR Analysis
PR Feedback
How to useInstructions
|
@@ -27,51 +27,57 @@ emissionFactors: | |||
battery discharge: | |||
- datetime: '2015-01-01' | |||
source: Electricity Maps, 2015 average | |||
value: 127.94998032394102 | |||
value: 157.89042611073754 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The values for the emission factors and the fallback zone mixes have been updated, but the source of these new values is not clear. It would be beneficial to include a comment or a source field indicating where these new values come from.
value: 157.89042611073754 | |
battery discharge: | |
- datetime: '2015-01-01' | |
source: Electricity Maps, 2015 average | |
value: 157.89042611073754 | |
# Updated based on new data from XYZ source |
@@ -95,25 +101,28 @@ emissionFactors: | |||
battery discharge: | |||
- datetime: '2015-01-01' | |||
source: Electricity Maps, 2015 average | |||
value: 169.1244092874929 | |||
value: 199.24199776578652 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The values for the emission factors and the fallback zone mixes have been updated, but the source of these new values is not clear. It would be beneficial to include a comment or a source field indicating where these new values come from.
value: 199.24199776578652 | |
battery discharge: | |
- datetime: '2015-01-01' | |
source: Electricity Maps, 2015 average | |
value: 199.24199776578652 | |
# Updated based on new data from XYZ source |
@@ -129,25 +138,28 @@ emissionFactors: | |||
hydro discharge: | |||
- datetime: '2015-01-01' | |||
source: Electricity Maps, 2015 average | |||
value: 169.1244092874929 | |||
value: 199.24199776578652 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The values for the emission factors and the fallback zone mixes have been updated, but the source of these new values is not clear. It would be beneficial to include a comment or a source field indicating where these new values come from.
value: 199.24199776578652 | |
hydro discharge: | |
- datetime: '2015-01-01' | |
source: Electricity Maps, 2015 average | |
value: 199.24199776578652 | |
# Updated based on new data from XYZ source |
datetime: '2021-01-01' | ||
value: | ||
battery discharge: 1.5563816477945657e-10 | ||
biomass: 0.025025869366431176 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The values for the emission factors and the fallback zone mixes have been updated, but the source of these new values is not clear. It would be beneficial to include a comment or a source field indicating where these new values come from.
datetime: '2021-01-01' | |
value: | |
battery discharge: 1.5563816477945657e-10 | |
biomass: 0.025025869366431176 | |
datetime: '2021-01-01' | |
value: | |
battery discharge: 1.5563816477945657e-10 | |
biomass: 0.025025869366431176 | |
coal: 0.053366299671417566 | |
# Updated based on new data from XYZ source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue
Description
Update discharge emission factors and overrides following the update of the unknown emission factor in #6032
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier --write .
andpoetry run format
to format my changes.