refactor(parser structure): Refactor IS parser

[unitrium]

Description

Refactoring the IS parser to use the new datastructure.

Preview

Testing is currently pending because the website seems to be down so I can't get a test sample.

Double check

• I have tested my parser changes locally with poetry run test_parser "zone_key"
• I have run pnpx prettier --write . and poetry run format to format my changes.

[github-actions]

PR Analysis

• 🎯 Main theme: Refactoring the IS parser to use a new data structure.
• 📝 PR summary: The PR involves refactoring the IS parser to use a new data structure. The changes include removing the old IS.py file and adding a new file amper_landsnet.py with the updated parser. The new parser now uses the ProductionMix and ProductionBreakdownList models from the electricitymap.contrib.lib.models module.
• 📌 Type of PR: Refactoring
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2, because the PR is relatively small and straightforward, involving refactoring of a single parser. The changes are clear and well-structured.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR is well-structured and the code is clean. However, it would be beneficial to include tests for the new parser to ensure its correct functionality. Also, it would be helpful to provide more context in the PR description about the reasons for the refactoring and the benefits of the new data structure.

• 🤖 Code feedback:

  ---

  relevant file	parsers/amper_landsnet.py
  suggestion	Consider handling the case when the 'geothermal', 'hydro', or 'oil' keys are not present in the response JSON. This will make your code more robust to potential changes in the API response. [important]
  relevant line	mix = ProductionMix(

  ---

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[github-actions]

Suggestion: It's better to separate the creation of the Session object from the fetch_production function. This way, the same Session can be reused across multiple requests, which can improve performance by reusing the underlying TCP connection.

Suggested change

	def fetch_production(
	zone_key: ZoneKey = ZoneKey("IS"),
	session: Session | None = None,
	target_datetime: datetime | None = None,
	logger: Logger = getLogger(__name__),
	) -> list[dict]:
	"""Requests the last known production mix (in MW) of a given country."""
	r = session or Session()
	def fetch_production(
	zone_key: ZoneKey = ZoneKey("IS"),
	session: Session,
	target_datetime: datetime | None = None,
	logger: Logger = getLogger(__name__),
	) -> list[dict]:
	"""Requests the last known production mix (in MW) of a given country."""

[github-actions]

Suggestion: It's a good practice to check if the response from the server is in the expected format before accessing its content. This can prevent unexpected errors.

Suggested change

	obj = res.json()
	mix = ProductionMix(
	geothermal=obj["geothermal"],
	hydro=obj["hydro"],
	oil=obj["oil"],
	)
	obj = res.json()
	if not all(key in obj for key in ["geothermal", "hydro", "oil"]):
	raise ParserException(
	parser="amper_landsnet.py",
	message=f"Response from {SOURCE} is missing expected keys",
	zone_key=zone_key,
	)
	mix = ProductionMix(
	geothermal=obj["geothermal"],
	hydro=obj["hydro"],
	oil=obj["oil"],
	)

[VIKTORVAV99]

I think the endpoint is configured to only accept our production server IP and IPs in Iceland. So might be hard to get a a sample.

The changes look good though!

[unitrium]

Ah ok that might explain some stuff! I will try to get a sample through a proxy