-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parser validation): Refactor BD part 1 #6265
Conversation
PR Analysis
PR Feedback
How to useInstructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll mark the flagged code as used in tests later today 🙂
I have dismissed the warnings but I actually agree that I could sanitize the html input a bit, people will execute this test on their computers. |
Description
I'm starting a refactor of this parser. To avoid a big messy PR I'm splitting it into smaller PRs.
This PR just renames the parser and create a baseline test which would make sure that subsequent PRs don't break anything.
Double check
poetry run test_parser "zone_key"
pnpx prettier --write .
andpoetry run format
to format my changes.