-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parser-validation): refactor BD part 2 #6267
Conversation
PR Analysis
PR Feedback
How to useInstructions
|
3a4a7fc
to
dcbcb34
Compare
Can be reviewed now, the other part has been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected.
There is a small type error though but it should not impact runtime functionality, would be good to double check this in the follow up PR for production parsing though.
@@ -166,7 +164,7 @@ def query( | |||
parser="BD.py", | |||
message=("Could not find table header in returned HTML."), | |||
) | |||
verify_table(table_head) | |||
verify_table_header(table_head) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does cause some type errors as the table head can be of Tag | NavigatableString | Int but I don't think it will cause any runtime issues as it is right now.
row_data.append( | ||
{ | ||
"time": datetime.combine(parsed_day, parsed_time, tzinfo=TIMEZONE), | ||
"total_generation": table_entry_to_float(row_items[2]), # MW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also add a parser function for this?
I know it's not really used by us right now but would be nice to start collecting these to use in validation rules in the future?
To be reviewed after the other PR to fix names has been merged.
Description
Double check
poetry run test_parser "zone_key"
pnpx prettier --write .
andpoetry run format
to format my changes.