Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NZ parser: Update oil for name change #6269

Merged
merged 3 commits into from
Dec 29, 2023
Merged

NZ parser: Update oil for name change #6269

merged 3 commits into from
Dec 29, 2023

Conversation

drc38
Copy link
Contributor

@drc38 drc38 commented Dec 20, 2023

Issue

Description

Updates the parser to match the latest descriptions from Transpower for the Oil category

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier --write . and poetry run format to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Dec 20, 2023
VIKTORVAV99
VIKTORVAV99 requested changes Dec 22, 2023
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change needed then this will look good, thanks for doig this.

parsers/NZ.py Outdated Show resolved Hide resolved
parsers/NZ.py Outdated Show resolved Hide resolved
VIKTORVAV99
VIKTORVAV99 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this parser!

@VIKTORVAV99 VIKTORVAV99 merged commit 8ee5cba into electricitymaps:master Dec 29, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIKTORVAV99 VIKTORVAV99 VIKTORVAV99 approved these changes

Assignees
No one assigned
Labels
parser python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drc38 @VIKTORVAV99